Introduce NotionReminder for Notion Collections #49
Conversation
notion/collection.py
Outdated
| if not val: | ||
| val = "" | ||
| if not isinstance(val, str): | ||
| if not isinstance(val, (str,list)): |
There was a problem hiding this comment.
Nit: space after commas (but I'll do a pass with black after which will clean things up).
There was a problem hiding this comment.
Also, I totally forgot that you can pass a tuple of types to isinstance -- nice!
There was a problem hiding this comment.
Can you clarify the case in which we'd be passing in a list here, though? Is this for when you'd want to use the native/internal notion format externally?
There was a problem hiding this comment.
Same situation I didn'ŧ realize that I made pull request from master. Maybe I will do another pull request for this feature. But the main idea is, that I want to pass format that is not representable by markdown - e,g, text and backgroud colors, user mentions, dates etc. [text, ['h', color]], [' @' + client.get_user(user_id).full_name, [['b']]]
xzavrel
force-pushed
the
master
branch
2 times, most recently
from
776d48b to
31a8420
Compare
|
Thanks again for the proposed changes! Ended up merging #239, a slightly simpler approach to handling reminders. Let me know if that doesn't work for your needs. |
2 participants
This adds new NotionReminder class aligned with NotionDate so it's possible to create and parse reminders in Collections. I have added also very brief example.