Skip to content

Conversation

@Spomky
Copy link
Contributor

@Spomky Spomky commented Nov 21, 2025

This PR adds PHP8.5 support, updates some dev dependencies and the README file.

@Spomky Spomky force-pushed the features/php8.5-support branch from 8594e17 to fe8c372 Compare November 21, 2025 14:16
@jakzal
Copy link
Owner

jakzal commented Nov 25, 2025

bin/devkit.php needs to be updated (see #507).

@jakzal
Copy link
Owner

jakzal commented Nov 25, 2025

Sorry, you'll get a conflict for roave-backward-compatibility-check since I merged #546

@jakzal
Copy link
Owner

jakzal commented Nov 26, 2025

@Spomky thank you for working on this!

I resolved some conflicts. I think you'll also need to revert the scurtinizer change.

Please update bin/devkit.php to include PHP 8.5 (see how it was done before). Next, run the following command to update the readme file:

bin/devkit.php update:readme

@Spomky Spomky force-pushed the features/php8.5-support branch 2 times, most recently from 67ec6d4 to dd12f5b Compare November 26, 2025 09:30
@Spomky
Copy link
Contributor Author

Spomky commented Nov 26, 2025

Many thanks.
The PR is rebased on master. I reverted the scrutinizer changes and updated bin/devkit.php as aksed.
Let me know if something is missing.

@jakzal
Copy link
Owner

jakzal commented Nov 26, 2025

Thanks, now it's the case of waiting for the build and possibly excluding more tools from running with PHP 8.5 if the build fails.

@Spomky
Copy link
Contributor Author

Spomky commented Nov 26, 2025

Indeed it looks like Roave/BackwardCompatibilityCheck#940 is need first (and this dependency also needs another one).

@jakzal
Copy link
Owner

jakzal commented Nov 26, 2025

@Spomky the exclude tag seems to have got lost somewhere in the merge/rebase.

@Spomky
Copy link
Contributor Author

Spomky commented Nov 26, 2025

OK changed. Let's see what happen

@jakzal
Copy link
Owner

jakzal commented Nov 27, 2025

twigcs doesn't work on PHP 8.5 and needs to be excluded. Once done, something else might come up. You'll see the failing check at the bottom of the build, like here: https://github.com/jakzal/toolbox/actions/runs/19703339364/job/56448635521?pr=543#step:5:2038

image

@jakzal
Copy link
Owner

jakzal commented Dec 9, 2025

@Spomky do you have time to finish this?

@Spomky Spomky force-pushed the features/php8.5-support branch from 8603a53 to 0f3d9dd Compare December 14, 2025 09:36
@Spomky
Copy link
Contributor Author

Spomky commented Dec 14, 2025

@jakzal the PR is rebased, no conflicts and twigcs is now excluded as well.

@jakzal
Copy link
Owner

jakzal commented Dec 15, 2025

codeception now :D

@Spomky Spomky force-pushed the features/php8.5-support branch from 0f3d9dd to 1c1a5b3 Compare December 18, 2025 14:13
@Spomky
Copy link
Contributor Author

Spomky commented Dec 18, 2025

Hi,

PR rebased and tools excluded.
I am facing rate limits. I gues we should wait a moment before running the tests again.

@jakzal jakzal merged commit 9485a79 into jakzal:master Dec 19, 2025
17 of 21 checks passed
@jakzal
Copy link
Owner

jakzal commented Dec 19, 2025

Thank you @Spomky 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants