-
-
Notifications
You must be signed in to change notification settings - Fork 28
Add PHP 8.5 support in configuration files #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8594e17 to
fe8c372
Compare
|
bin/devkit.php needs to be updated (see #507). |
|
Sorry, you'll get a conflict for roave-backward-compatibility-check since I merged #546 |
|
@Spomky thank you for working on this! I resolved some conflicts. I think you'll also need to revert the scurtinizer change. Please update |
67ec6d4 to
dd12f5b
Compare
|
Many thanks. |
|
Thanks, now it's the case of waiting for the build and possibly excluding more tools from running with PHP 8.5 if the build fails. |
|
Indeed it looks like Roave/BackwardCompatibilityCheck#940 is need first (and this dependency also needs another one). |
|
@Spomky the exclude tag seems to have got lost somewhere in the merge/rebase. |
dd12f5b to
8603a53
Compare
|
OK changed. Let's see what happen |
|
|
|
@Spomky do you have time to finish this? |
8603a53 to
0f3d9dd
Compare
|
@jakzal the PR is rebased, no conflicts and |
|
|
0f3d9dd to
1c1a5b3
Compare
|
Hi, PR rebased and tools excluded. |
|
Thank you @Spomky 🍺 |

This PR adds PHP8.5 support, updates some dev dependencies and the README file.