InvalidArgumentException on heartbeat set to zero #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws InvalidArgumentException on zero heartbeat.
Setting heartbeat to zero usually means heartbeat is disabled (or value from the server is used) - i.e. php-amqplib/RabbitMqBundle#552
Currently, setting heartbeat to zero in bunny causes DoS on the rabbit server - in my case it caused 1 Mpps rate with 1 Gbps traffic and the CPU load has been maxed out on our rabbit server. So no one realistically wants this behavior.
It took me quite some time to debug this (initially I thought it was caused due to forking and some async issues).
I believe I may not be the only one setting this to zero thinking it would disable the heartbeat like on other implementations.