Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support of bytes type of AMQP field #139

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support of bytes type of AMQP field #139

wants to merge 1 commit into from

Conversation

F0Rt04ka
Copy link

@F0Rt04ka F0Rt04ka commented Jun 1, 2023

Add support of bytes type of AMQP field.

I got error "Unhandled field type 0x78 ('x')" and found fix in php-amqplib

https://github.com/php-amqplib/php-amqplib/blob/6bf2e5c49759fc386a4988f3af1761cbfb63d367/PhpAmqpLib/Wire/AMQPReader.php#L402

@WyriHaximus WyriHaximus added this to the v0.6.0 milestone Aug 1, 2023
@WyriHaximus WyriHaximus added the bug label Aug 1, 2023
WyriHaximus
WyriHaximus requested changes Aug 1, 2023
View reviewed changes
Copy link
Collaborator

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer, if there are unit tests for the long string to also included tests for the bytes type to be honest. Assuming this is testable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus requested changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@F0Rt04ka @WyriHaximus