Skip to content

Commit

Permalink
build: Warn when using snapshot on Armv6
Browse files Browse the repository at this point in the history
Building io.js on armv6 with snapshot enabled does not work due to a bug in v8,
so it now warns when building on armv6 and having snapshot enabled.

PR-URL: nodejs#282
Reviewed-By: Rod Vagg <rod@vagg.org>
  • Loading branch information
Cydox authored and rvagg committed Jan 12, 2015
1 parent d51efd0 commit 0cca6fe
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions configure
Original file line number Diff line number Diff line change
Expand Up @@ -944,4 +944,8 @@ else:

gyp_args += args

#print warning when snapshot is enabled and building on armv6
if (is_arch_armv6()) and (not options.without_snapshot):
print '\033[1;33mWarning!! When building on ARMv6 use --without-snapshot\033[1;m'

sys.exit(subprocess.call(gyp_args))

0 comments on commit 0cca6fe

Please sign in to comment.