Move utility methods into a utils module #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 4, 2020 14:09
Change the tests to use new utils module.
jaketf
requested changes
Dec 4, 2020
| "writeDisposition": "WRITE_APPEND", | ||
| "labels": DEFAULT_JOB_LABELS, | ||
| } | ||
| from .utils import (DEFAULT_JOB_LABELS, SUCCESS_FILENAME, cached_get_bucket, |
Owner
There was a problem hiding this comment.
style: let's just make this
import .utils as utilsand then use the prefix everywhere functions are used
e.g.
utils.create_job_id_prefix(...)Reasoning: google style guide for imports https://google.github.io/styleguide/pyguide.html#22-imports
nit: let's make another module for constants and move them all there.
Reasoning: We might add more modules that depend on these constants which are not really utilities.
DEFAULT_JOB_LABELS
SUCCESS_FILENAME
DEFAULT_DESTINATION_REGEX
CLIENT_INFO
JOB_POLL_INTERVAL_SECONDS
BASE_LOAD_JOB_CONFIG
DEFAULT_MAX_BATCH_BYTES
MAX_SOURCE_URIS_PER_LOAD
SUCCESS_FILENAME
DEFAULT_JOB_PREFIX
Collaborator
Author
There was a problem hiding this comment.
I made the updates requested
Change import pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the tests to use new utils module.