Version tags #31
Version tags #31
Conversation
It should no longer be necessary to return zero friction when velocities or heights are low. Such conditional friction expressions were left over from old code.
These changes give a universal user-settable interface to the various desingularisation choices made in the numerics and were cherry-picked from dc67611. Co-authored-by: Jake Langham <jacob.langham@manchester.ac.uk>
* New TopogFunc flume that generalizes USGS * corrected flume walls * Document general usgs flume geometry + small clarification to usgs geometry documentation. * Add new topos: trislope and 2 simple channels * xtrislope missing x index --------- Co-authored-by: Mark Woodhouse <mark.woodhouse@bristol.ac.uk>
* Add GDAL dependency linker flags These extra linker flags are needed for builds on some systems. * Avoid -march flags on non-linux builds
This action automatically checks that kestrel builds successfully and that all tests pass, triggered when trying to update testing or main. Test logs are saved as artifacts in case of failure.
|
Hi @markwoodhouse - as it stands, this would merge in some things into main from testing that may be unintentional, like the desingularisation stuff. If you want to create a pull request with just the 'version tags' changes, the way to do it (or one way at least) is to branch off main with something like |
|
Ok, thanks. I'll do this. |
Addresses #2
Gets version from git tags in configure.ac, passed through -D flags in compilation, (clunky) read in cversion.cpp and passed to fortran version.f90.
Version tag added to RunInfo.txt and netcdf files as a global attribute in Output.f90
Version tag checked when reading files in Restart.f90 -- warning issued if stored version different from current installed Kestrel version.