Get Mail Platform TCK into a Runnable State #2097
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
None that I could find
Related Issue(s)
None
Describe the change
Gets the Mail TCK into a runnable state, as it doesn't currently resolve.
This is done by removing an undefined (and redundant) property.
Also fixes an incorrect module name under
glassfish-runner
.I've also removed the need to define the TS_HOME environment variable and set it to glassfish-runner/mail-platform-tck/jakartaeetck, as the runner doesn't seem to actually expect it to be variable? It uses this directory to find the certificates and config files.
To coincide with this, I have made a distinction between the home and work directories so that it does not leave config files the runner generates behind in there (which git is not configured to ignore).
Please correct me if this is in fact meant to be adjustable and I will remove those commits.
Additional context
I could not find an active Jenkins job for the Mail TCK in the Eclipse CI, I assume it is meant to be this one but it's inactive.
If there is one and everything is green please feel free to disregard this PR (and point me at where this is please!).
The TCK does not pass for me locally on Java 17 or 21, but it at least now runs.
A few tests pass, but then the TCK seems to hit some ClassNotFoundExceptions on its own test classes (for a yet to be discerned reason), and then hangs.
ClassNotFound:
Hang: