-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Example changes to get the persistence tests running for all vehicles… #2049
Conversation
… in the ee.jakarta.tck.persistence.core.annotations.basic package. Related #1998 Signed-off-by: Scott M Stark <starksm@starkinternational.com>
I built the issue1998 branch locally but get test failures:
|
What do the errors look like? I think I also had to run using Java SE 17 or
something was not working.
…On Fri, Mar 7, 2025 at 12:03 PM Scott Marlow ***@***.***> wrote:
I built the issue1998 branch locally but get test failures:
mvn -Pfull,appclient -DskipSBOM test-compile
***@***.*** | tee /tmp/run.log
...
Tests run: 17, Failures: 0, Errors: 17, Skipped: 0
—
Reply to this email directly, view it on GitHub
<#2049 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACRDMQ7I2UDHWPYHLEDM232THNOFAVCNFSM6AAAAABYQMDTXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBXGA3TONBTGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
[image: scottmarlow]*scottmarlow* left a comment
(jakartaee/platform-tck#2049)
<#2049 (comment)>
I built the issue1998 branch locally but get test failures:
mvn -Pfull,appclient -DskipSBOM test-compile
***@***.*** | tee /tmp/run.log
...
Tests run: 17, Failures: 0, Errors: 17, Skipped: 0
—
Reply to this email directly, view it on GitHub
<#2049 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACRDMQ7I2UDHWPYHLEDM232THNOFAVCNFSM6AAAAABYQMDTXSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMBXGA3TONBTGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I did use Java SE 17 also. From console output I see:
From GF server.log, first error is:
|
I think this indicates that the tcks/apis/persistence/persistence-inside-container/spec-tests/src/main/resources/com/sun/ts/tests/common/vehicle/appmanaged/appmanaged_vehicle_client.xml still has the old ejb-ref in it. It should just be empty like this: <application-client xmlns="https://jakarta.ee/xml/ns/jakartaee" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" version="10" xsi:schemaLocation="https://jakarta.ee/xml/ns/jakartaee https://jakarta.ee/xml/ns/jakartaee/application-client_10.xsd">
</application-client> |
I just pulled down the platform-tck and checked out the issue1998 branch on a fedora vm and installed the tck from the platform-tck build, and then ran the tests from the platform-tck/glassfish-runner/persistence-platform-tck/persistence-platform-tck-run directory. It is passing for me.
I would remove all of your ~/.m2/repository/jakarta/tck contents and make sure you do the platform-tck install using -Dmaven.build.cache.enabled=false to ensure you are getting the issue1998 branch contents. |
Signed-off-by: Scott M Stark <starksm64@gmail.com>
my last run of this branch:
|
Nice progress! I'm still not sure why I cannot run locally (I have the right source ejb vehicle xml file is empty in source tree). I'll see if I can update a CI Jenkins job to run against the changes. |
…lass Signed-off-by: Scott M Stark <starksm@starkinternational.com>
Signed-off-by: Scott M Stark <starksm@starkinternational.com>
Remove the fixed jndi name for stateless3 vehicle ejb Signed-off-by: Scott M Stark <starksm@starkinternational.com>
Latest changes has:
Still seeing some deployment errors. |
Signed-off-by: Scott M Stark <starksm@starkinternational.com>
So the results should be getting better, but a full run is now showing:
One package that shows all failures in this run is
so we have some cross test pollution that is causing failures in the full run. |
So I just ran it again to see what the order of failing tests were, and it was passing at 98.5%?
and the only errors were:
Some of these tests like |
Signed-off-by: Scott M Stark <starksm@starkinternational.com>
Again I saw a run with only around 4000 test passing and 500 errors. It looks like the issue is the glassfish container plugin is leaving a bunch of /tmp/gf_uploadsNNN files and the tmp filesystem on the vm I'm testing with is filling up. I have cleared these out and am rerunning to verify. |
The latest run, 98.9% passing:
|
I created this question about being able to delete the gf_uploads* files: |
… in the ee.jakarta.tck.persistence.core.annotations.basic package.
With these changes the web profile tck-javatest tests pass:
and the full platform tck-appclient tests pass:
Related Issue(s)
Related #1998