Voice channel mention

[lorivaro]

This pull request...

• Fixes a bug
• Introduces a new feature
• Improves an existing feature
• Boosts code quality or performance

Description

I recently noticed voice channels can be mentioned just like text channels. A small change to the code can implement this feature.

The top example is the current way the bot would mention a channel, the bottom is what I wish it would look like.
This is my first pull request. I have not tested this change as I consider it to be too simple and don't expect it to fail.

Purpose

Aesthetics and ease of use: clicking on the mentioned channel will automatically connect you to it.

[MichailiK]

JDA offers a method to get a channel's mention string. Use that method instead.

[MichailiK]

Additionally, my IDE has found another 3 usages of the voice channel name that you've missed:

MusicBot/src/main/java/com/jagrosh/jmusicbot/audio/AudioHandler.java

Line 205 in b83028f

mb.append(FormatUtil.filter(manager.getBot().getConfig().getSuccess()+" **Now Playing in "+guild.getSelfMember().getVoiceState().getChannel().getName()+"...**"));

MusicBot/src/main/java/com/jagrosh/jmusicbot/commands/general/SettingsCmd.java

Line 60 in b83028f

+ "\nVoice Channel: " + (vchan == null ? "Any" : "**" + vchan.getName() + "**")

MusicBot/src/main/java/com/jagrosh/jmusicbot/utils/FormatUtil.java

Line 77 in b83028f

out+="\n - "+list.get(i).getName()+" (ID:"+list.get(i).getId()+")";

Please update these as well.

[lorivaro]

Thanks for the elaborate feedback.
I agree with getAsMention() being more appropriate than "<#"+vc.getId()+">".
I also applied these changes to the 3 other usages that I had missed earlier.

After successfully compiling the project, I ran the commands and got some good results, a few of which you can see below:

[MichailiK]

Looks good! @jagrosh will have to take another look & merge if everything looks good.