Move track command #218
Merged
Move track command #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for moving a track in queue.
jagrosh
requested changes
Apr 8, 2019
src/main/java/com/jagrosh/jmusicbot/commands/dj/MoveTrackCmd.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jagrosh/jmusicbot/commands/dj/MoveTrackCmd.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jagrosh/jmusicbot/commands/dj/MoveTrackCmd.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jagrosh/jmusicbot/commands/dj/MoveTrackCmd.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jagrosh/jmusicbot/commands/dj/MoveTrackCmd.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jagrosh/jmusicbot/commands/dj/MoveTrackCmd.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jagrosh/jmusicbot/commands/dj/MoveTrackCmd.java
Outdated
Show resolved
Hide resolved
jagrosh
reviewed
Apr 9, 2019
src/main/java/com/jagrosh/jmusicbot/commands/dj/MoveTrackCmd.java
Outdated
Show resolved
Hide resolved
jagrosh
reviewed
Apr 9, 2019
src/main/java/com/jagrosh/jmusicbot/commands/dj/MoveTrackCmd.java
Outdated
Show resolved
Hide resolved
jagrosh
approved these changes
Apr 9, 2019
|
Thanks for your contribution! |
|
Might want to rebase+squash my three commits into one, if you want to tidy up the commit history. And thank you for this bot. :) |
|
I don't mind a few extra commits for fixes, and rebase+squash would mess up github's contributor graph |
faejr
pushed a commit
to faejr/MusicBot
that referenced
this pull request
May 8, 2021
Move track command
ElerWohlmuthFH
pushed a commit
to ElerWohlmuthFH/MusicBot
that referenced
this pull request
Sep 20, 2024
Move track command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for moving a track in queue.
This pull request...
Description
Adds
?movetrack <from> <to>command to move the queued item<from>to the specified position<to>.Purpose
Adds more control to the queue. Implemented as DJ command.
Notes from the author
Implemented this in my own fork which uses a different code style (braces etc). I manually tried to get it in line with the upstream (your) repository, but an automated refactor might be wise.