Fix missing deps on react #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Strict package managers like pnpm, yarn in pnp or pnpm mode won't allow next-secure-headers to access react.
So here's a fix. I've added react as dependency with a large range (16, 17 and 18).
For @types/node as it's seems only internal and typescript only, I just added them as an optional peerDependency... But it's not required, so I can remove it if you feel so.
By the way, thanks for this great lib.
PS:
As a workaround for yarn 2 or 3, it's possible to add the following in the yarnrc.yml