-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move over internal ingester code to OSS #940
Conversation
Codecov Report
@@ Coverage Diff @@
## master #940 +/- ##
======================================
Coverage 100% 100%
======================================
Files 126 136 +10
Lines 6080 6322 +242
======================================
+ Hits 6080 6322 +242
Continue to review full report at Codecov.
|
What is this commit trying to achieve? |
I wasn't able to find a easy way to exclude a single file from a package from coverage. Renaming with a The mock is not in a separate mocks package because the consumer interface it is mocking was declared private. |
Signed-off-by: Prithvi Raj <p.r@uber.com>
Build fails because of #945 |
Which problem is this PR solving?
Short description of the changes