[fix] Fix incorrect usage of iter package in aggregator #6403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6403 +/- ##
==========================================
- Coverage 96.27% 96.25% -0.03%
==========================================
Files 367 367
Lines 20978 20978
==========================================
- Hits 20197 20192 -5
- Misses 597 601 +4
- Partials 184 185 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Dec 25, 2024
| # TODO: remove once we have upgraded to Go 1.23 | ||
| disallow-iter: | ||
| deny: | ||
| - pkg: iter |
There was a problem hiding this comment.
this is very odd - our go.mod says
go 1.22.7
so it should not have compiled w/ the std iter package
yurishkuro
approved these changes
Dec 25, 2024
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this pull request
Jan 5, 2025
…g#6403) ## Description of the changes - jaegertracing#6401 was accidentally using the official `iter` package instead of the internal one. This PR fixes that usage. - Added a linter rule so we don't accidentally use the official package again until we upgrade to Go 1.23 ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <mahadzaryab1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
iterpackage instead of the internal one. This PR fixes that usage.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test