Respond correctly to stream send error #6357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
commented
Dec 14, 2024
| @@ -155,6 +155,9 @@ func TestFindTraces(t *testing.T) { | |||
| Attributes: map[string]string{"foo": "bar"}, | |||
| StartTimeMin: time.Now().Add(-2 * time.Hour), | |||
| StartTimeMax: time.Now(), | |||
| DurationMin: 1 * time.Second, | |||
| DurationMax: 2 * time.Second, | |||
| SearchDepth: 10, | |||
There was a problem hiding this comment.
to increase code coverage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6357 +/- ##
==========================================
+ Coverage 96.06% 96.11% +0.05%
==========================================
Files 357 357
Lines 20357 20355 -2
==========================================
+ Hits 19555 19565 +10
+ Misses 611 603 -8
+ Partials 191 187 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?