-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Perses to monitor example #6149
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6149 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 353 353
Lines 20107 20107
=======================================
Hits 19398 19398
Misses 524 524
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
What's the objective? |
@yurishkuro we can use Grafana and Perses to demo the metrics now. Perses is another visualization tool for time series which is part of CNCF. As you are aware Grafana's license could change at some point, so this is nice to have for demo/testing purposes. |
I think we should remove grafana as well. The point of the example is to demonstrate SPM capability, not the metrics generation. For debugging purposes Prometheus has a basic UI. |
While I agree with you, we have to think about the user.... Most Jaeger users are also using Grafana which is open source today, so I think it's nice to demo. Grafana can also visualize the Jaeger data which is nice to show. |
We also need to think about Jaeger the project. Grafana was added when it only had metrics. Now it's a direct competitor with Jaeger UI. |
When I show both in a demo, I explain how Grafana doesn't have the search or other capabilities Jaeger has, however if you want to visualize a trace, they are both capable, same with OpenSearch. The fact is that pretty much every Prometheus user is using Grafana, hence they would likely be using it with Jaeger. These are the facts until Perses gains popularity over the next several years, I hope. |
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test