Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spm] Remove Grafana from examples #6148

Merged
merged 3 commits into from
Nov 2, 2024

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Nov 1, 2024

Which problem is this PR solving?

  • Grafana server was not necessary for demonstrating SPM behavior or debugging

Description of the changes

  • Remove grafana service
  • Update readme

How was this change tested?

Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
@pavolloffay pavolloffay requested a review from a team as a code owner November 1, 2024 08:57
@dosubot dosubot bot added the docker Pull requests that update Docker code label Nov 1, 2024
Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (e80645b) to head (c342f60).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6148       +/-   ##
===========================================
+ Coverage   48.89%   96.47%   +47.57%     
===========================================
  Files         178      354      +176     
  Lines       10761    20107     +9346     
===========================================
+ Hits         5262    19398    +14136     
+ Misses       5058      524     -4534     
+ Partials      441      185      -256     
Flag Coverage Δ
badger_v1 8.32% <ø> (ø)
badger_v2 1.68% <ø> (ø)
cassandra-4.x-v1 14.40% <ø> (ø)
cassandra-4.x-v2 1.62% <ø> (ø)
cassandra-5.x-v1 14.40% <ø> (ø)
cassandra-5.x-v2 1.62% <ø> (ø)
elasticsearch-6.x-v1 18.53% <ø> (ø)
elasticsearch-7.x-v1 18.61% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v1 18.78% <ø> (ø)
elasticsearch-8.x-v2 1.68% <ø> (ø)
grpc_v1 9.50% <ø> (ø)
grpc_v2 7.00% <ø> (-0.01%) ⬇️
kafka-v1 8.89% <ø> (ø)
kafka-v2 1.68% <ø> (ø)
memory_v2 1.67% <ø> (-0.02%) ⬇️
opensearch-1.x-v1 18.66% <ø> (+<0.01%) ⬆️
opensearch-2.x-v1 18.65% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 1.68% <ø> (+0.01%) ⬆️
tailsampling-processor 0.47% <ø> (ø)
unittests 95.38% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavolloffay pavolloffay added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Nov 1, 2024
yurishkuro and others added 2 commits November 1, 2024 20:52
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro changed the title Fix monitor example by aligning metrics namespace to new default [spm] Remove Grafana from examples Nov 2, 2024
@yurishkuro yurishkuro enabled auto-merge (squash) November 2, 2024 00:54
@yurishkuro yurishkuro merged commit b644701 into jaegertracing:main Nov 2, 2024
48 of 50 checks passed
yurishkuro added a commit to yurishkuro/jaeger that referenced this pull request Nov 2, 2024
@jkowall jkowall mentioned this pull request Nov 4, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG docker Pull requests that update Docker code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants