-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[spm] Remove Grafana from examples #6148
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6148 +/- ##
===========================================
+ Coverage 48.89% 96.47% +47.57%
===========================================
Files 178 354 +176
Lines 10761 20107 +9346
===========================================
+ Hits 5262 19398 +14136
+ Misses 5058 524 -4534
+ Partials 441 185 -256
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pavolloffay
added
the
changelog:skip
Trivial change that does not require an entry in CHANGELOG
label
Nov 1, 2024
yurishkuro
reviewed
Nov 1, 2024
Signed-off-by: Yuri Shkuro <github@ysh.us>
yurishkuro
changed the title
Fix monitor example by aligning metrics namespace to new default
[spm] Remove Grafana from examples
Nov 2, 2024
yurishkuro
approved these changes
Nov 2, 2024
yurishkuro
added a commit
to yurishkuro/jaeger
that referenced
this pull request
Nov 2, 2024
This reverts commit b644701.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog:skip
Trivial change that does not require an entry in CHANGELOG
docker
Pull requests that update Docker code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?