Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Remove command echoing #6126

Merged
merged 1 commit into from
Oct 27, 2024
Merged

[fix] Remove command echoing #6126

merged 1 commit into from
Oct 27, 2024

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

Description of the changes

  • Remove echoing of commands from upload script
  • remove test file that doesn't check much

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro added the changelog:skip Trivial change that does not require an entry in CHANGELOG label Oct 26, 2024
@yurishkuro yurishkuro requested a review from a team as a code owner October 26, 2024 21:34
@yurishkuro
Copy link
Member Author

@mahadzaryab1 stamp please

Copy link

codecov bot commented Oct 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (85d558d) to head (586a49f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6126   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files         353      353           
  Lines       20112    20112           
=======================================
  Hits        19394    19394           
  Misses        533      533           
  Partials      185      185           
Flag Coverage Δ
badger_v1 8.34% <ø> (ø)
badger_v2 1.69% <ø> (ø)
cassandra-4.x-v1 14.43% <ø> (ø)
cassandra-4.x-v2 1.63% <ø> (ø)
cassandra-5.x-v1 14.43% <ø> (ø)
cassandra-5.x-v2 1.63% <ø> (ø)
elasticsearch-6.x-v1 18.54% <ø> (ø)
elasticsearch-7.x-v1 18.63% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v1 18.79% <ø> (ø)
elasticsearch-8.x-v2 1.69% <ø> (+0.01%) ⬆️
grpc_v1 9.37% <ø> (+<0.01%) ⬆️
grpc_v2 7.03% <ø> (ø)
kafka-v1 8.91% <ø> (ø)
kafka-v2 1.69% <ø> (ø)
memory_v2 1.69% <ø> (+0.01%) ⬆️
opensearch-1.x-v1 18.68% <ø> (ø)
opensearch-2.x-v1 18.67% <ø> (ø)
opensearch-2.x-v2 1.68% <ø> (-0.02%) ⬇️
tailsampling-processor 0.48% <ø> (ø)
unittests 95.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 6a0a5c5 into main Oct 27, 2024
50 checks passed
@yurishkuro yurishkuro deleted the fix-3842 branch October 27, 2024 03:13
yurishkuro added a commit to yurishkuro/jaeger that referenced this pull request Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Trivial change that does not require an entry in CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants