skip nil and zero length hits, fix #556 #601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus on the flowing multiread function code snippet
when trace id is invalid or not in the es store, we got response json as follows:
and then the response json is unmarshalled to the
elastic.MultiSearchResult
struct, you will notice that the snippetwill not get nil
result.Hits
, but a zero lengthresult.Hits.Hits
.When
len(result.Hits.Hits) == 0
,collectSpans
will return[]*model.Span
with zero length and no error.In this case, got result traces as
this results that
len(traces) == 0
not triggered, and then noerrNoTraces
is returned.As explained above, neither nil
result.Hits
nor zero lengthresult.Hits.Hits
should do the followingcollectSpans
, just skip them.