Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OpenTelemetry SDK to v1.22.0 #5137

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

chirag-ghosh
Copy link
Contributor

@chirag-ghosh chirag-ghosh commented Jan 23, 2024

Which problem is this PR solving?

Description of the changes

  • Upgrade OTel SDK to v1.22 (dependabot)
  • Upgrade semconv version to v1.24 (Reference issue). I tried using semconv v1.22 but it was still failing.
  • Replace deprecated function semconv.HTTPStatusCodeKey with semconv.HTTPResponseStatusCodeKey

How was this change tested?

Checklist

dependabot bot and others added 3 commits January 19, 2024 05:00
Bumps the otel group with 5 updates:

| Package | From | To |
| --- | --- | --- |
| [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) | `1.21.0` | `1.22.0` |
| [go.opentelemetry.io/otel/exporters/otlp/otlptrace](https://github.com/open-telemetry/opentelemetry-go) | `1.21.0` | `1.22.0` |
| [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc](https://github.com/open-telemetry/opentelemetry-go) | `1.21.0` | `1.22.0` |
| [go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp](https://github.com/open-telemetry/opentelemetry-go) | `1.21.0` | `1.22.0` |
| [go.opentelemetry.io/otel/exporters/stdout/stdouttrace](https://github.com/open-telemetry/opentelemetry-go) | `1.21.0` | `1.22.0` |


Updates `go.opentelemetry.io/otel` from 1.21.0 to 1.22.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.21.0...v1.22.0)

Updates `go.opentelemetry.io/otel/exporters/otlp/otlptrace` from 1.21.0 to 1.22.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.21.0...v1.22.0)

Updates `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc` from 1.21.0 to 1.22.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.21.0...v1.22.0)

Updates `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp` from 1.21.0 to 1.22.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.21.0...v1.22.0)

Updates `go.opentelemetry.io/otel/exporters/stdout/stdouttrace` from 1.21.0 to 1.22.0
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.21.0...v1.22.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: otel
- dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: otel
- dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: otel
- dependency-name: go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: otel
- dependency-name: go.opentelemetry.io/otel/exporters/stdout/stdouttrace
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: otel
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
Signed-off-by: Chirag Ghosh <cghosh828049@gmail.com>
@chirag-ghosh chirag-ghosh requested a review from a team as a code owner January 23, 2024 09:52
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (88efe47) 95.62% compared to head (827d47a) 95.63%.
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #5137    +/-   ##
========================================
  Coverage   95.62%   95.63%            
========================================
  Files         322      324     +2     
  Lines       18454    18590   +136     
========================================
+ Hits        17647    17778   +131     
- Misses        649      651     +2     
- Partials      158      161     +3     
Flag Coverage Δ
cassandra-3.x 25.58% <ø> (-0.01%) ⬇️
cassandra-4.x 25.58% <ø> (-0.01%) ⬇️
elasticsearch-5.x 19.86% <ø> (-0.01%) ⬇️
elasticsearch-6.x 19.85% <ø> (-0.03%) ⬇️
elasticsearch-7.x 20.00% <ø> (-0.01%) ⬇️
elasticsearch-8.x 20.07% <ø> (-0.03%) ⬇️
grpc-badger 19.48% <ø> (-0.03%) ⬇️
kafka 14.09% <ø> (-0.01%) ⬇️
opensearch-1.x 20.00% <ø> (+<0.01%) ⬆️
opensearch-2.x 19.98% <ø> (-0.03%) ⬇️
unittests 93.33% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro added the changelog:dependencies Update to dependencies label Jan 24, 2024
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit 8c00cc1 into jaegertracing:main Jan 24, 2024
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:dependencies Update to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade OpenTelemetry SDK to v1.22.0
2 participants