Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Thrift compiler to v0.19 and regenerate types #5080

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • Use latest version of Thrift compiler

Description of the changes

  • Upgrade to v0.19 Docker image of Thrift compiler
  • Regenerate types

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
Copy link

github-actions bot commented Jan 4, 2024

Test Results

2 083 tests  ±0   2 073 ✅ ±0   1m 8s ⏱️ ±0s
  220 suites ±0      10 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 8745bd5. ± Comparison against base commit a7c5ef0.

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e4d7f34) 95.54% compared to head (8745bd5) 95.56%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5080      +/-   ##
==========================================
+ Coverage   95.54%   95.56%   +0.02%     
==========================================
  Files         313      316       +3     
  Lines       18210    18322     +112     
==========================================
+ Hits        17398    17510     +112     
  Misses        652      652              
  Partials      160      160              
Flag Coverage Δ
cassandra-3.x 25.59% <ø> (ø)
cassandra-4.x 25.59% <ø> (ø)
elasticsearch-5.x 19.87% <ø> (ø)
elasticsearch-6.x 19.87% <ø> (ø)
elasticsearch-7.x 19.99% <ø> (-0.02%) ⬇️
elasticsearch-8.x 20.10% <ø> (ø)
grpc-badger 19.51% <ø> (+0.01%) ⬆️
kafka 14.10% <ø> (ø)
opensearch-1.x 19.99% <ø> (ø)
opensearch-2.x 20.01% <ø> (+0.01%) ⬆️
unittests 93.25% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro marked this pull request as ready for review January 4, 2024 20:26
@yurishkuro yurishkuro requested a review from a team as a code owner January 4, 2024 20:26
@yurishkuro yurishkuro merged commit 42304f3 into jaegertracing:main Jan 4, 2024
40 of 41 checks passed
@yurishkuro yurishkuro deleted the thrift-0.19 branch January 4, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant