Upload test report #5035
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| name: Unit Test Results | ||
|
|
||
| on: | ||
| workflow_run: | ||
| workflows: ["Unit Tests"] | ||
| types: | ||
| - completed | ||
|
|
||
| jobs: | ||
| unit-test-results: | ||
|
There was a problem hiding this comment. Why is it necessary to separate this into a different workflow? Doing so requires all the juggling with artifact files. Can we not do all it at once directly in the unit test workflow, where we already call publish reports action? There was a problem hiding this comment.
It's a valid question, because one would think the action to execute the unit test and generate the results artifact is done as part of this repo's CI pipeline, so the relevant files should be easily accessible. In fact, we're trying to do that now (publish test results as a comment to this PR) because, I agree, it's a lot simpler than juggling artifact uploads and downloads; but it's failing with this error message (from example run):
I don't fully understand why, but from the log message, it almost sounds like a security measure to prevent PRs from another fork from writing to a PR owned by the "parent" repo, which seems to make sense. Can you see any other alternative? |
||
| name: Unit Test Results | ||
| runs-on: ubuntu-latest | ||
|
|
||
| permissions: | ||
| checks: write | ||
|
|
||
| # Needed unless run with comment_mode: off. | ||
| pull-requests: write | ||
|
|
||
| # Required by download step to access artifacts API. | ||
| actions: read | ||
|
|
||
| steps: | ||
| - name: Harden Runner | ||
| uses: step-security/harden-runner@eb238b55efaa70779f274895e782ed17c84f2895 # v2.6.1 | ||
| with: | ||
| egress-policy: audit # TODO: change to 'egress-policy: block' after couple of runs | ||
|
|
||
| - name: Download and Extract Artifacts | ||
| uses: dawidd6/action-download-artifact@v3 | ||
|
There was a problem hiding this comment. do we know what's different about it? It's preferable to use official actions like https://github.com/actions/download-artifact There was a problem hiding this comment. Not specifically, but I did spend a good number of hours trying out actions/download-artifact without any luck. Oddly, it wasn't able to discover the uploaded files, but there may have been a silly mistake on my part 🤷🏼 Happy to take suggestions! |
||
| with: | ||
| run_id: ${{ github.event.workflow_run.id }} | ||
| path: artifacts | ||
|
|
||
| - name: Publish Test Results | ||
| uses: EnricoMi/publish-unit-test-result-action@v2 | ||
| with: | ||
| commit: ${{ github.event.workflow_run.head_sha }} | ||
| event_file: artifacts/Event File/event.json | ||
| event_name: ${{ github.event.workflow_run.event }} | ||
| files: "artifacts/**/*.xml" | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file needs to be merged into
mainfirst before we can see the results of the test report summary in PRs, which is why we can't see it in this PR.