Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Go Tip installation into sub-action #5020

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

image

Description of the changes

  • Move Go Tip installation into a separate sub-action
  • Add some debug logging to see the progress to make it easier to debug in case of failures (right now it's hard to tell which step is actually failing and resulting in the errors above)

How was this change tested?

image

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner December 19, 2023 15:41
@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (09080e6) 95.60% compared to head (f020c6a) 95.60%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5020   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files         319      319           
  Lines       18786    18786           
=======================================
  Hits        17960    17960           
  Misses        663      663           
  Partials      163      163           
Flag Coverage Δ
cassandra-3.x 25.63% <ø> (ø)
cassandra-4.x 25.63% <ø> (ø)
elasticsearch-5.x 19.89% <ø> (ø)
elasticsearch-6.x 19.89% <ø> (-0.02%) ⬇️
elasticsearch-7.x 20.04% <ø> (+0.01%) ⬆️
elasticsearch-8.x 20.13% <ø> (ø)
grpc-badger 19.52% <ø> (ø)
kafka 14.12% <ø> (ø)
opensearch-1.x 20.04% <ø> (ø)
opensearch-2.x 20.04% <ø> (+0.01%) ⬆️
unittests 93.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jkowall jkowall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@yurishkuro yurishkuro merged commit d4b0373 into jaegertracing:main Dec 19, 2023
38 checks passed
@yurishkuro yurishkuro deleted the go-tip-action branch December 19, 2023 15:58
@yurishkuro
Copy link
Member Author

yurishkuro commented Dec 19, 2023

And, by coincidence, the build just failed with this change, and I was even able to reproduce:

$ curl -fsSL https://storage.googleapis.com/go-build-snap/go/linux-amd64/03242506def60494d1b7231e2be57ea2f07f27a8.tar.gz -o gotip.tar.gz
curl: (22) The requested URL returned error: 404

Note that while I was testing the change a few minutes ago the HEAD commit of Go was 52dbffeac86863e1e0c9455b5b216ec50c828946. So it is possible we have a race condition between new commit showing on HEAD and the build becoming available from go-build-snap

4min later it's there. Maybe we could have some retry loop in the action.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants