Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Makefile #4882

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Simplify Makefile #4882

merged 1 commit into from
Oct 22, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • Makefile has a lot of unnecessary copy/pasted redundancies

Description of the changes

  • Remove all -debug targets which only set a couple variables - set them differently

How was this change tested?

  • CI

Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro requested a review from a team as a code owner October 22, 2023 20:43
@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro added the changelog:ci Change related to continuous integration / testing label Oct 22, 2023
@yurishkuro yurishkuro merged commit 92ba189 into jaegertracing:main Oct 22, 2023
33 of 34 checks passed
@yurishkuro yurishkuro deleted the makefile branch October 22, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:ci Change related to continuous integration / testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant