Fix build-all-in-one-image script

[albertteoh]

Description of the changes

• Fixes this error in CI builds and may explain why the jaeger all-in-one v1.50 image is missing in docker hub:

+ '[main' '!=' 'pr-only]'
scripts/build-all-in-one-image.sh: line 57: [main: command not found

How was this change tested?

• Tested using a simple bash script to reproduce the problem.

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits

[codecov]

Codecov Report

All modified lines are covered by tests ✅

see 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

[yurishkuro]

usually double [[]] are used for expressions

[yurishkuro]

if it's missing from docker hub, the workflow should've failed, let's make sure this happens

[yurishkuro]

Suggested change

	if [ "$mode" != "pr-only" ]; then
	if [[ "$mode" != "pr-only" ]]; then

[yurishkuro]

I think the reason there is no 1.50 image is because the build did not recognize semver tag and published this as latest only:

+ docker buildx build --output 'type=image, push=true' --progress=plain --target release --build-arg base_image=localhost:5000/baseimg_alpine:latest --build-arg debug_image=localhost:5000/debugimg_alpine:latest --platform=linux/amd64,linux/s390x,linux/ppc64le,linux/arm64 --file cmd/all-in-one/Dockerfile --tag docker.io/jaegertracing/all-in-one --tag docker.io/jaegertracing/all-in-one:latest --tag quay.io/jaegertracing/all-in-one --tag quay.io/jaegertracing/all-in-one:latest --tag docker.io/jaegertracing/all-in-one-snapshot:2bb7ee46f8f8ed9310515f4e68eca32afeae4589 --tag quay.io/jaegertracing/all-in-one-snapshot:2bb7ee46f8f8ed9310515f4e68eca32afeae4589 cmd/all-in-one

[yurishkuro]

So the workflow was indeed successful. My other fix should solve that, hopefully.

[albertteoh]

if it's missing from docker hub, the workflow should've failed, let's make sure this happens

I was wondering why we didn't get a non-zero exit status on this failure even though we have set -exu.

From this SO answer:

The exit status of the if command shall be the exit status of the then or else compound-list that was executed, or zero, if none was executed.

So since the then block wasn't executed, it just defaults to zero.

I'm not sure if there's anything reasonable we can do except making sure we use the correct bash syntax.

[albertteoh]

I'm not sure if there's anything reasonable we can do except making sure we use the correct bash syntax.

Perhaps we could do something to prevent this sort of error like using https://github.com/koalaman/shellcheck (github action available: https://github.com/marketplace/actions/shellcheck).

What do you think?

[yurishkuro]

great idea -- #4822