Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotrod] Move metrics endpoints from route to frontend service #4720

Merged
merged 3 commits into from
Sep 4, 2023
Merged

[hotrod] Move metrics endpoints from route to frontend service #4720

merged 3 commits into from
Sep 4, 2023

Conversation

yurishkuro
Copy link
Member

Which problem is this PR solving?

  • Previously, for unexplained reasons, the metrics endpoints (/metrics and /debug/expvar) in HotROD were served from the route service. That means 8083 port was also required to be exposed.

Description of the changes

  • Move metrics handlers to the frontend service
  • Return error from root service

How was this change tested?

$ curl http://0.0.0.0:8083/metrics
endpoint moved to the frontend service

@yurishkuro yurishkuro requested a review from a team as a code owner September 4, 2023 13:19
@yurishkuro
Move metrics services to frontend
89fb68e 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
moved
c39e341 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro
changelog
96cc909 
Signed-off-by: Yuri Shkuro <github@ysh.us>
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro changed the title Hotrod move metrics [hotrod] Move metrics endpoints from route to frontend service Sep 4, 2023
@yurishkuro yurishkuro merged commit 0daccea into jaegertracing:main Sep 4, 2023
31 checks passed
@yurishkuro yurishkuro deleted the hotrod-move-metrics branch September 4, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkowall jkowall Awaiting requested review from jkowall jkowall is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yurishkuro