-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support spanmetrics connector by default #4704
Conversation
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
@@ -64,7 +64,7 @@ func NewOptions(primaryNamespace string) *Options { | |||
ServerURL: defaultServerURL, | |||
ConnectTimeout: defaultConnectTimeout, | |||
|
|||
SupportSpanmetricsConnector: false, | |||
SupportSpanmetricsConnector: defaultSupportSpanmetricsConnector, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the main (breaking) change.
The other changes relate to local developer improvements with a similar theme of defaulting to the spanmetrics connector as well.
If we feel those changes should be decoupled into separate PRs, I'm happy to break them up.
Signed-off-by: albertteoh <see.kwang.teoh@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4704 +/- ##
==========================================
+ Coverage 97.04% 97.05% +0.01%
==========================================
Files 301 301
Lines 17880 17880
==========================================
+ Hits 17352 17354 +2
+ Misses 423 422 -1
+ Partials 105 104 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@@ -29,7 +29,7 @@ service: | |||
traces: | |||
receivers: [otlp, jaeger] | |||
processors: [batch] | |||
exporters: [spanmetrics, jaeger] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jaeger exporter is deprecated, hence the switch to otlp exporter.
Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com> Signed-off-by: Albert <26584478+albertteoh@users.noreply.github.com>
Which problem is this PR solving?
Description of the changes
PROMETHEUS_QUERY_SUPPORT_SPANMETRICS_CONNECTOR
parameter totrue
.run
target in favour ofdocker compose up
.run-
prefix of the remaining targets.How was this change tested?
Checklist
- [] I have added unit tests for the new functionalityjaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test