[zipkin] Replace zipkin exporter from jaeger sdk with otel zipkin exp #4674
+48
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
reviewed
Aug 15, 2023
afzal442
force-pushed
the
replace-jaeger-sdk-zipkinExp-with-otel-zexp
branch
from
76de075
to
386a7d5
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4674 +/- ##
==========================================
- Coverage 97.04% 97.02% -0.02%
==========================================
Files 301 301
Lines 17878 17878
==========================================
- Hits 17350 17347 -3
- Misses 423 425 +2
- Partials 105 106 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Aug 15, 2023
yurishkuro
reviewed
Aug 17, 2023
afzal442
force-pushed
the
replace-jaeger-sdk-zipkinExp-with-otel-zexp
branch
from
fa15e7e
to
feea6ff
Compare
Signed-off-by: Afzal Ansari <afzal442@gmail.com>
Signed-off-by: afzal442 <afzal442@gmail.com>
Signed-off-by: afzal442 <afzal442@gmail.com>
Signed-off-by: afzal442 <afzal442@gmail.com>
Signed-off-by: afzal442 <afzal442@gmail.com>
afzal442
force-pushed
the
replace-jaeger-sdk-zipkinExp-with-otel-zexp
branch
from
feea6ff
to
68034d6
Compare
afzal442
commented
Aug 17, 2023
yurishkuro
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
zipkin expfrom jaeger sdk and replaces it with otel zipkin exp