feat: add span.Warnings to cassandra schema #4217
Conversation
Signed-off-by: Rohan Kumar <rohankmr414@gmail.com>
|
@albertteoh do I also need to include some sort of migration for cassandra schema |
| start_time, duration, tags, logs, refs, process, warnings) | ||
| VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)` |
There was a problem hiding this comment.
This won't work because there is no warning field in the table schema.
Considering how much headache it is to add a new column (need to version schema, invent some backwards compatibility logic, etc.), perhaps a less disruptive solution would be to encode warnings in either tags or logs, with a magic string prefix for tag names, so that they can be recognized at read time and converted back to warnings.
There was a problem hiding this comment.
For example, we could create tags like this:
$$span.warning.1 = {warning1}$$span.warning.2 = {warning2}
There was a problem hiding this comment.
Should we be concerned about the length of the warning (string) we receive in the span? Or do we directly encode the entire warning as is?
There was a problem hiding this comment.
warnings come from our code, they are not very long. And we generally do not have restrictions on tag value length.
There was a problem hiding this comment.
Alternative implementation in #4313
|
Replaced by #4313 |
## Which problem is this PR solving? - Resolves #705 - Resolves #704 ## Short description of the changes - Instead of creating a separate column in the table, [we encode warnings as tags, with a magic string prefix](#4217 (comment)) so that they can be parsed and converted back to warnings during reads. --------- Signed-off-by: Utsav Oza <utsavoza96@gmail.com>
Which problem is this PR solving?
Short description of the changes
Span.Warningsto Cassandradbmodel.Span