Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remote-storage service #3836

Merged
merged 9 commits into from
Aug 2, 2022
Merged

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Aug 1, 2022

Part of #3835

  • add tests

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #3836 (487f0d4) into main (ea71bd1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##             main    #3836    +/-   ##
========================================
  Coverage   97.62%   97.63%            
========================================
  Files         291      293     +2     
  Lines       16955    17067   +112     
========================================
+ Hits        16553    16663   +110     
- Misses        317      319     +2     
  Partials       85       85            
Impacted Files Coverage Δ
ports/ports.go 100.00% <ø> (ø)
cmd/remote-storage/app/flags.go 100.00% <100.00%> (ø)
cmd/remote-storage/app/server.go 100.00% <100.00%> (ø)
pkg/tenancy/grpc.go 100.00% <100.00%> (ø)
plugin/storage/grpc/options.go 100.00% <100.00%> (ø)
pkg/config/tlscfg/cert_watcher.go 92.55% <0.00%> (-2.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea71bd1...487f0d4. Read the comment docs.

Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro marked this pull request as ready for review August 2, 2022 02:51
@yurishkuro yurishkuro requested a review from a team as a code owner August 2, 2022 02:51
Signed-off-by: Yuri Shkuro <github@ysh.us>
@yurishkuro yurishkuro merged commit 4daa4e9 into jaegertracing:main Aug 2, 2022
@yurishkuro yurishkuro deleted the remote-store branch August 2, 2022 04:54
albertteoh pushed a commit to albertteoh/jaeger that referenced this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant