Added windows zip file generation #3817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhithyasrinivasan
changed the title
adhithyasrinivasan
force-pushed
the
Feat-WindowsZipBin
branch
from
f7755ee
to
a1fb43e
Compare
yurishkuro
reviewed
Jul 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #3817 +/- ##
=======================================
Coverage 97.59% 97.59%
=======================================
Files 291 291
Lines 16939 16939
=======================================
Hits 16532 16532
Misses 321 321
Partials 86 86 Continue to review full report at Codecov.
|
…g#3814) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.36.0 to 0.37.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](prometheus/common@v0.36.0...v0.37.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Adhithya Srinivasan <adhithya.srinivasan@walmart.com>
Signed-off-by: Adhithya Srinivasan <adhithya.srinivasan@walmart.com>
Signed-off-by: Adhithya Srinivasan <adhithya.srinivasan@walmart.com>
adhithyasrinivasan
force-pushed
the
Feat-WindowsZipBin
branch
from
b048000
to
8e96d8b
Compare
Ashmita152
added a commit
to Ashmita152/jaeger
that referenced
this pull request
Aug 5, 2022
Earlier we used to have tar.gz for windows release. jaegertracing#3817 changed the windows release from tar.gz to zip format. This PR also restores that i.e. now we have both tar.gz and zip for windows release.
Ashmita152
added a commit
to Ashmita152/jaeger
that referenced
this pull request
Aug 5, 2022
Earlier we used to have tar.gz for windows release. jaegertracing#3817 changed the windows release from tar.gz to zip format. This PR also restores that i.e. now we have both tar.gz and zip for windows release. Signed-off-by: Ashmita152 <ashmita.bohara@logz.io>
yurishkuro
pushed a commit
that referenced
this pull request
Aug 5, 2022
Earlier we used to have tar.gz for windows release. #3817 changed the windows release from tar.gz to zip format. This PR also restores that i.e. now we have both tar.gz and zip for windows release. Signed-off-by: Ashmita152 <ashmita.bohara@logz.io>
albertteoh
pushed a commit
to albertteoh/jaeger
that referenced
this pull request
Aug 8, 2022
albertteoh
pushed a commit
to albertteoh/jaeger
that referenced
this pull request
Aug 8, 2022
Earlier we used to have tar.gz for windows release. jaegertracing#3817 changed the windows release from tar.gz to zip format. This PR also restores that i.e. now we have both tar.gz and zip for windows release. Signed-off-by: Ashmita152 <ashmita.bohara@logz.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
Signed-off-by: adhithyasrinivasan [adhithyasrinivasan@gmail.com)