Fix base path in grpc gateway for api_v3 #3139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay
commented
Jul 14, 2021
| @@ -34,7 +34,11 @@ func RegisterGRPCGateway(ctx context.Context, logger *zap.Logger, r *mux.Router, | |||
| grpcGatewayMux := runtime.NewServeMux( | |||
| runtime.WithMarshalerOption(runtime.MIMEWildcard, jsonpb), | |||
| ) | |||
| r.PathPrefix("/v3/").Handler(http.StripPrefix(basePath, grpcGatewayMux)) | |||
There was a problem hiding this comment.
this was causing the issue. The default base path is passed as /. The StripPrefix is noop only when the base path is empty and the old tests were testing only empty base path.
Codecov Report
@@ Coverage Diff @@
## master #3139 +/- ##
==========================================
- Coverage 95.93% 95.87% -0.06%
==========================================
Files 239 239
Lines 10525 10528 +3
==========================================
- Hits 10097 10094 -3
- Misses 352 357 +5
- Partials 76 77 +1
Continue to review full report at Codecov.
|
jpkrohling
approved these changes
Jul 14, 2021
yurishkuro
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay p.loffay@gmail.com
Changes: