Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query service with OTLP #3086

Merged
merged 16 commits into from
Jul 13, 2021
Merged

Add query service with OTLP #3086

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e8083b9
Add query service with OTLP
pavolloffay Jun 10, 2021
eb20c77
Fix issues
pavolloffay Jul 1, 2021
cdcf987
use TLS
pavolloffay Jul 1, 2021
c370a27
Test TLS in grpc gateway
pavolloffay Jul 1, 2021
a1055c8
annoying
pavolloffay Jul 1, 2021
49ca286
Fix
pavolloffay Jul 1, 2021
720bcf7
return error
pavolloffay Jul 1, 2021
5fd2b72
fix
pavolloffay Jul 1, 2021
b66da70
Fix
pavolloffay Jul 2, 2021
2d25ea6
update idl
pavolloffay Jul 2, 2021
627cd28
Fix
pavolloffay Jul 2, 2021
2734142
Handle cancelation
pavolloffay Jul 2, 2021
5ddba04
Fix vet
pavolloffay Jul 2, 2021
0e983b8
Add test and remove swagger
pavolloffay Jul 2, 2021
2e5f644
Change comment
pavolloffay Jul 6, 2021
0b215b3
Fix review comments
pavolloffay Jul 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix vet 
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
  • Loading branch information
@pavolloffay
pavolloffay committed Jul 13, 2021
commit 5ddba0453c4f3f0976e284992ebdbbcc41ed4cbb
1 change: 1 addition & 0 deletions cmd/query/app/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ func createHTTPServer(querySvc *querysvc.QueryService, metricsQuerySvc querysvc.

ctx, cancelFunc := context.WithCancel(context.Background())
if err := apiv3.RegisterGRPCGateway(ctx, logger, r, queryOpts.BasePath, queryOpts.GRPCHostPort, queryOpts.TLSGRPC); err != nil {
cancelFunc() // make go vet happy
return nil, nil, err
}

Expand Down