Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in comment in mapping.go #2939

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Conversation

fenggw-fnst
Copy link
Contributor

Signed-off-by: Guangwen Feng fenggw-fnst@cn.fujitsu.com

Which problem is this PR solving?

  • Fix a typo

Short description of the changes

  • Fix typo in comment in mapping.go

Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
@fenggw-fnst fenggw-fnst requested a review from a team as a code owner April 15, 2021 06:28
@fenggw-fnst fenggw-fnst requested a review from joe-elliott April 15, 2021 06:28
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #2939 (116b619) into master (c5642b7) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2939      +/-   ##
==========================================
+ Coverage   95.90%   95.97%   +0.07%     
==========================================
  Files         223      223              
  Lines        9712     9712              
==========================================
+ Hits         9314     9321       +7     
+ Misses        328      323       -5     
+ Partials       70       68       -2     
Impacted Files Coverage Δ
plugin/storage/es/mappings/mapping.go 100.00% <ø> (ø)
plugin/storage/integration/integration.go 77.34% <0.00%> (-0.56%) ⬇️
...lugin/sampling/strategystore/adaptive/processor.go 100.00% <0.00%> (+0.92%) ⬆️
cmd/collector/app/server/zipkin.go 76.92% <0.00%> (+3.84%) ⬆️
cmd/query/app/static_handler.go 96.77% <0.00%> (+4.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5642b7...116b619. Read the comment docs.

@joe-elliott joe-elliott merged commit 312f83b into jaegertracing:master Apr 15, 2021
@joe-elliott
Copy link
Member

Thanks for the fix!

@fenggw-fnst fenggw-fnst deleted the work branch April 16, 2021 00:27
@jpkrohling jpkrohling added this to the Release 1.23.0 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants