Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better variable for archive suffix #2854

Merged
merged 2 commits into from
Feb 26, 2021

Conversation

albertteoh
Copy link
Contributor

Signed-off-by: albertteoh albert.teoh@logz.io

Short description of the changes

  • Fix variable name from Prefix to the more appropriate Suffix

Signed-off-by: albertteoh <albert.teoh@logz.io>
@albertteoh albertteoh requested a review from a team as a code owner February 26, 2021 12:11
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #2854 (8a4b6d0) into master (c01aa2b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2854   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files         222      222           
  Lines        9696     9696           
=======================================
  Hits         9301     9301           
- Misses        325      327    +2     
+ Partials       70       68    -2     
Impacted Files Coverage Δ
plugin/storage/es/spanstore/reader.go 100.00% <100.00%> (ø)
pkg/config/tlscfg/cert_watcher.go 92.20% <0.00%> (-2.60%) ⬇️
...lugin/sampling/strategystore/adaptive/processor.go 99.07% <0.00%> (-0.93%) ⬇️
plugin/storage/badger/spanstore/reader.go 96.08% <0.00%> (+0.71%) ⬆️
cmd/query/app/server.go 97.08% <0.00%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c01aa2b...f421fa2. Read the comment docs.

@yurishkuro yurishkuro merged commit 0d2fd6b into jaegertracing:master Feb 26, 2021
albertteoh added a commit to albertteoh/jaeger that referenced this pull request Mar 5, 2021
Signed-off-by: albertteoh <albert.teoh@logz.io>
@albertteoh albertteoh deleted the better-var-name branch March 8, 2021 03:51
@jpkrohling jpkrohling added this to the Release 1.23.0 milestone Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants