Use fork of Apache Thrift

[jpkrohling]

Temporarily use a personal fork of Apache Thrift, tagged with 1.13.1, which includes the fix for THRIFT-5322 (apache/thrift#2292).
Fixes #2638 and fixes #2452.
The issue to track the reversion of this PR is #2781.

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

[objectiser]

@jpkrohling Would be good to create an issue to revert the change once an official version is available, and link within the description of this PR.

[codecov]

Codecov Report

Merging #2780 (4c9096c) into master (8e5eb9b) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2780      +/-   ##
==========================================
+ Coverage   95.89%   95.90%   +0.01%     
==========================================
  Files         217      217              
  Lines        9625     9625              
==========================================
+ Hits         9230     9231       +1     
  Misses        326      326              
+ Partials       69       68       -1     

Impacted Files	Coverage Δ
plugin/storage/integration/integration.go	77.34% <0.00%> (-0.56%)	⬇️
plugin/storage/badger/spanstore/reader.go	96.08% <0.00%> (+0.71%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e5eb9b...dc11c46. Read the comment docs.

[jpkrohling]

@Mario-Hofstaetter, @zigmund, would you be open to testing an image with this PR, to confirm that your problems will get fixed?

[Mario-Hofstaetter]

@jpkrohling Will do, hope to get it done by friday.
Is there a download available for a windows binary?

[yurishkuro]

I thought we wanted the fork to be in github.com/jaegertracing. Why use personal fork?

[jpkrohling]

I can push my fork to the jaegertracing organization, but it makes that somewhat too "official". I really want this to be temporary.

[yurishkuro]

We can reflect that in the forked repo description. Btw pushing to a new repo from yours will not establish the forked link on GitHub.

[zigmund]

@jpkrohling yes, I can test image in few days.

[jpkrohling]

Btw pushing to a new repo from yours will not establish the forked link on GitHub

Yes, sorry, I meant that I would fork Apache Thrift to jaegertracing org and push the tag there.

[jpkrohling]

PR updated to use the fork from the jaegertracing organization.