Add status command #2684
Merged
Add status command #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Zhengwei <chenzhengwei@inspur.com> Signed-off-by: chen zhengwei <chenzhengwei@inspur.com>
Signed-off-by: Chen Zhengwei <chenzhengwei@inspur.com>
Codecov Report
@@ Coverage Diff @@
## master #2684 +/- ##
==========================================
+ Coverage 95.51% 95.60% +0.08%
==========================================
Files 214 215 +1
Lines 9546 9579 +33
==========================================
+ Hits 9118 9158 +40
+ Misses 348 344 -4
+ Partials 80 77 -3
Continue to review full report at Codecov.
|
Signed-off-by: Chen Zhengwei <chenzhengwei@inspur.com> Signed-off-by: chen zhengwei <chenzhengwei@inspur.com>
yurishkuro
reviewed
Dec 10, 2020
cmd/status/command_test.go
Outdated
| defer ts.Close() | ||
| v := viper.New() | ||
| cmd := Command(v, 80) | ||
| cmd.ParseFlags([]string{"--status.http.host-port=" + strings.TrimPrefix(ts.URL, "http://127.0.0.1")}) |
There was a problem hiding this comment.
not sure if you're guaranteed to get URL having the exact 127.0.0.1 host (e.g. you could get IPv6 version instead). I'd rather read the port number as the part after the last :
Signed-off-by: Chen Zhengwei <chenzhengwei@inspur.com> Signed-off-by: chen zhengwei <chenzhengwei@inspur.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chen Zhengwei chenzhengwei@inspur.com
Which problem is this PR solving?
Short description of the changes
Usage:
<command> statuschecks the localhost and the port of the corresponding component.<command> status --status.http.host-portchecks for a specific port or URL.