Address review comments from #2655

[albertteoh]

Signed-off-by: albertteoh albert.teoh@logz.io

Which problem is this PR solving?

• Addresses remaining comments from @yurishkuro in Move cert loading failure assertion on client public key write #2655.

Short description of the changes

• Shorten best case scenario conditional wait time.
• Leverage assert's formatted string support.

[yurishkuro]

thanks

[yurishkuro]

weird, staticcheck failed, but did not print the log

https://github.com/jaegertracing/jaeger/pull/2673/checks?check_run_id=1478025515#step:5:40

[albertteoh]

weird, staticcheck failed, but did not print the log

https://github.com/jaegertracing/jaeger/pull/2673/checks?check_run_id=1478025515#step:5:40

I reported the issue here: #2674
Seems to be a flaky test?

[yurishkuro]

The linter ran before the tests:

time staticcheck ./... \
	| grep -v \
		-e model/model.pb.go \
		-e thrift-gen/ \
	>> .lint.log || true
Command exited with non-zero status 1

[albertteoh]

Yes, sorry, I missed that. It is odd and I'd expect that to exit early too. Just ran it locally and returned a 0 status code (IIUC, should this always return a 0 status code with || true?):

$ staticcheck ./... \
	| grep -v \
		-e model/model.pb.go \
		-e thrift-gen/ \
	>> .lint.log || true
$ echo $?
0

[codecov]

Codecov Report

Merging #2673 (d33beaf) into master (a7be3a8) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2673      +/-   ##
==========================================
- Coverage   95.56%   95.54%   -0.03%     
==========================================
  Files         214      214              
  Lines        9535     9535              
==========================================
- Hits         9112     9110       -2     
- Misses        345      346       +1     
- Partials       78       79       +1     

Impacted Files	Coverage Δ
cmd/query/app/server.go	88.52% <0.00%> (-1.64%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7be3a8...d33beaf. Read the comment docs.

[yurishkuro]

I rerun the job and it succeeded