Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky TestReload #2646

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

albertteoh
Copy link
Contributor

@albertteoh albertteoh commented Nov 24, 2020

Signed-off-by: albertteoh albert.teoh@logz.io

Which problem is this PR solving?

Short description of the changes

Testing

The following test run passes locally:

go test -test.count=5000 -test.run=TestReload$ ./pkg/config/tlscfg/

@albertteoh albertteoh requested a review from a team as a code owner November 24, 2020 05:32
@albertteoh albertteoh requested a review from vprithvi November 24, 2020 05:32
Signed-off-by: albertteoh <albert.teoh@logz.io>
@yurishkuro
Copy link
Member

We could merge this if the branch build is successful: https://travis-ci.org/github/albertteoh/jaeger/builds/745572554 (since our main build is out of credits)

@albertteoh
Copy link
Contributor Author

We could merge this if the branch build is successful: https://travis-ci.org/github/albertteoh/jaeger/builds/745572554 (since our main build is out of credits)

Thanks @yurishkuro . It looks like the build has just passed.

@yurishkuro yurishkuro merged commit 88e9a70 into jaegertracing:master Nov 24, 2020
@albertteoh albertteoh deleted the fix-flaky-TestReload branch November 26, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test pkg/config/tlscfg/TestReload (cert_watcher_test.go)
2 participants