Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend anonymizer with additional parameters #2585

Merged
merged 17 commits into from
Oct 29, 2020
Merged

Extend anonymizer with additional parameters #2585

merged 17 commits into from
Oct 29, 2020

Conversation

Ashmita152
Copy link
Contributor

Signed-off-by: Ashmita Bohara ashmita.bohara152@gmail.com

Which problem is this PR solving?

Partially fixes #2556

Short description of the changes

Extends the Anonymizer type with these additional parameters

  • hashStandardTags - when true, the allowsTags are also hashed, when false they are preserved as is
  • hashCustomTags - when true, all other tags are hashed, when false they are dropped (current behavior)
  • hashLogs - when true, logs are hashed, when false they are dropped (current behavior)
  • hashProcess - when true, process tags are hashed, when false they are dropped (current behavior)

Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
@Ashmita152 Ashmita152 requested a review from a team as a code owner October 23, 2020 13:35
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding unit tests

cmd/anonymizer/app/anonymizer/anonymizer.go Outdated Show resolved Hide resolved
cmd/anonymizer/app/anonymizer/anonymizer.go Outdated Show resolved Hide resolved
cmd/anonymizer/app/anonymizer/anonymizer.go Outdated Show resolved Hide resolved
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
@Ashmita152
Copy link
Contributor Author

Thank you for the feedbacks earlier. I have updated the PR with the feedbacks. It's ready for review again.

Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
@Ashmita152
Copy link
Contributor Author

Hi @yurishkuro

Thank you for the feedbacks earlier. I have updated the PR based on your feedback.

@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #2585 into master will decrease coverage by 0.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2585      +/-   ##
==========================================
- Coverage   95.31%   95.02%   -0.29%     
==========================================
  Files         208      209       +1     
  Lines        9285     9369      +84     
==========================================
+ Hits         8850     8903      +53     
- Misses        356      388      +32     
+ Partials       79       78       -1     
Impacted Files Coverage Δ
cmd/anonymizer/app/anonymizer/anonymizer.go 61.25% <100.00%> (ø)
pkg/testutils/logger.go 100.00% <100.00%> (ø)
...lugin/sampling/strategystore/adaptive/processor.go 99.07% <0.00%> (-0.93%) ⬇️
cmd/query/app/server.go 90.16% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee3bbee...1f8c3a7. Read the comment docs.

Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
@Ashmita152
Copy link
Contributor Author

Hi @yurishkuro

This PR is ready for review again. Thank you for your constant help.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yurishkuro yurishkuro merged commit 76b8fba into jaegertracing:master Oct 29, 2020
@Ashmita152 Ashmita152 deleted the anonymizer-1 branch October 29, 2020 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Finish implementing trace anonymizer
2 participants