-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TLS grpc connection on windows #2551
Conversation
Resolves jaegertracing#2550 Borrows workaround from Sensu: sensu/sensu-go#4018 Signed-off-by: Wouter Scheele <wscheele@sf.local> Signed-off-by: Wouter Scheele <wscheele@gmail.com>
9fa7938
to
fe336d4
Compare
CI restarted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to test this at all?
For what it's worth, I have deployed, and am using, the branch built windows agent; and it runs happily and reports to tls enabled collector. Without the workaround it just immediately bails out. running the v1.20.1 windows build with --reporter.grpc.tls.enabled=true (pointing to a tls endpoint) should reproduce it easily. I noticed I introduced some lint and test failures in the build, but am not too familiar with Go in general, and not at all familiar with this codebase and test setup specifically. I would be happy to enrich the PR with further changes to get a green build, but would appreciate some pointers in that case. |
The problem is that the Linux version of syscall doesn't have a // +build !windows And the first line for the Windows version: // +build windows You'll need to do the same for this PR here. You can use the same approach for tests: create a Windows-specific test in a separate source file, requiring |
Currently facing the same issue, so we are very eager for this merge - @wscheele would you kindly fix tests issues or you about to abandon it? |
I think this has been fixed by #2756 |
I'm running version 1.22.0 but I still get |
I am now running jaeger-all-in-one.exe version 1.32.0 under Windows 10 and still get |
Resolves #2550
Borrows workaround from Sensu:
sensu/sensu-go#4018
Signed-off-by: Wouter Scheele wscheele@gmail.com