Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create debug docker images for jaeger backends #2545

Merged
merged 8 commits into from
Oct 20, 2020
Merged

Create debug docker images for jaeger backends #2545

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9ea34fe
- Create debug docker images for jaeger backends
Ashmita152 Oct 9, 2020
3175215
Add builds for jaeger backend binaries with go optimizations disabled
Ashmita152 Oct 12, 2020
cdd9cc2
Moved base images build as separate
Ashmita152 Oct 12, 2020
6717613
Docker image naming change
Ashmita152 Oct 13, 2020
37bce77
Replaced CMD with ENTRYPOINT with some extra flags
Ashmita152 Oct 13, 2020
e19338c
Added changes for all-in-one binary and docker image
Ashmita152 Oct 14, 2020
2f352fc
Add a makefile directive to build base and debug images
Ashmita152 Oct 14, 2020
3d95017
Updated script to upload debug images to dockerhub
Ashmita152 Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Docker image naming change 
Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
  • Loading branch information
@Ashmita152
Ashmita152 committed Oct 20, 2020
commit 6717613dfc3d2384f72b9a8d768632bd31849a53
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ docker-images-jaeger-backend-debug: SUFFIX = -debug
docker-images-jaeger-backend docker-images-jaeger-backend-debug: create-baseimg create-debugimg
for component in agent collector query ingester ; do \
docker build --target $(TARGET) \
--tag $(DOCKER_NAMESPACE)/jaeger-$$component:${DOCKER_TAG}$(SUFFIX) \
--tag $(DOCKER_NAMESPACE)/jaeger-$$component$(SUFFIX):${DOCKER_TAG} \
--build-arg base_image=$(BASE_IMAGE) \
--build-arg debug_image=$(DEBUG_IMAGE) \
--build-arg TARGETARCH=$(GOARCH) \
Expand Down