Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable clock-skew-adjustment by default. #2513

Merged
merged 2 commits into from
Sep 25, 2020
Merged

Disable clock-skew-adjustment by default. #2513

merged 2 commits into from
Sep 25, 2020

Conversation

jpkrohling
Copy link
Contributor

Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de

Which problem is this PR solving?

Short description of the changes

  • Changed the default value for the flag query.max-clock-skew-adjustment to 0s.

Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@jpkrohling jpkrohling requested a review from a team as a code owner September 25, 2020 12:56
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #2513 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2513      +/-   ##
==========================================
- Coverage   95.21%   95.18%   -0.04%     
==========================================
  Files         208      208              
  Lines        9158     9158              
==========================================
- Hits         8720     8717       -3     
- Misses        363      365       +2     
- Partials       75       76       +1     
Impacted Files Coverage Δ
cmd/query/app/flags.go 100.00% <100.00%> (ø)
cmd/query/app/server.go 88.52% <0.00%> (-1.64%) ⬇️
plugin/storage/integration/integration.go 77.34% <0.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87799ea...fa1dd36. Read the comment docs.

@yurishkuro yurishkuro merged commit 1a199ba into jaegertracing:master Sep 25, 2020
@jpkrohling jpkrohling deleted the jpkrohling/1459-turn-off-clock-skew-by-default branch July 28, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clock Skew Adjuster considered harmful
3 participants