Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose tunning options via expvar #2496

Merged
merged 12 commits into from
Oct 5, 2020
Merged

Expose tunning options via expvar #2496

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bffbf4d
Expose tunning options via expvar
dstdfx Sep 21, 2020
5348411
Code clean up
dstdfx Sep 21, 2020
d682169
Fix tunning options exposion
dstdfx Sep 22, 2020
1d19d1d
Expose additional storage options
dstdfx Sep 22, 2020
6bed030
Call setExpvarOptions method inside Initialize
dstdfx Sep 22, 2020
772135b
Add span-storage.type options
dstdfx Sep 22, 2020
7a55c64
Fix test and expvar type
dstdfx Sep 22, 2020
86296f7
Fix falling test
dstdfx Sep 22, 2020
7e97b22
Use fork.Factory to store internal options
dstdfx Sep 28, 2020
0463d3b
Fix factory init, rename opts func
dstdfx Oct 1, 2020
9e54b11
Update jaeger-lib to v2.4.0
dstdfx Oct 2, 2020
e877351
Clean deps
dstdfx Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code clean up 
Signed-off-by: Daniil Rutskiy <dstdfx@gmail.com>
  • Loading branch information
@dstdfx
dstdfx committed Oct 5, 2020
commit 534841105695f5322371b9d187e040b81a5414a3
2 changes: 1 addition & 1 deletion cmd/agent/app/flags_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,4 +88,4 @@ func TestExposeTuningOptions(t *testing.T) {
assert.Equal(t, 4242, gotMaxPacketSize)
assert.Equal(t, 42, gotQueueSize)
assert.Equal(t, 42, gotWorkers)
}
}
1 change: 0 additions & 1 deletion cmd/collector/app/builder_flags.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ func (cOpts *CollectorOptions) InitFromViper(v *viper.Viper) *CollectorOptions {
return cOpts
}


// ExposeTuningOptions exposes collector's tuning options via expvar.
func ExposeTuningOptions(opts *CollectorOptions) {
expvar.NewInt(collectorNumWorkers).Set(int64(opts.NumWorkers))
Expand Down
2 changes: 1 addition & 1 deletion cmd/collector/app/builder_flags_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,4 +73,4 @@ func TestExposeTuningOptions(t *testing.T) {

assert.Equal(t, 42, gotNumWorkers)
assert.Equal(t, 42, gotQueueSize)
}
}