Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run the jaeger-agent as a non-root user by default #2466

Merged
merged 3 commits into from
Sep 14, 2020
Merged

Run the jaeger-agent as a non-root user by default #2466

merged 3 commits into from
Sep 14, 2020

Conversation

chgl
Copy link
Contributor

@chgl chgl commented Sep 10, 2020

Which problem is this PR solving?

Short description of the changes

  • Added a UID arg, defaulting to 10001, which the build image is running as by default.

@chgl chgl requested a review from a team as a code owner September 10, 2020 17:41
@chgl chgl requested a review from pavolloffay September 10, 2020 17:41
cmd/agent/Dockerfile Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #2466 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2466   +/-   ##
=======================================
  Coverage   95.51%   95.52%           
=======================================
  Files         208      208           
  Lines       10750    10750           
=======================================
+ Hits        10268    10269    +1     
  Misses        406      406           
+ Partials       76       75    -1     
Impacted Files Coverage Δ
cmd/query/app/server.go 89.14% <0.00%> (-1.56%) ⬇️
plugin/storage/integration/integration.go 80.38% <0.00%> (-0.48%) ⬇️
plugin/storage/badger/spanstore/reader.go 96.79% <0.00%> (+0.64%) ⬆️
cmd/query/app/static_handler.go 85.83% <0.00%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df2582d...feb8d42. Read the comment docs.

@jpkrohling
Copy link
Contributor

crossdock and unit tests CI jobs restarted.

@jpkrohling
Copy link
Contributor

CI looks good. @chgl, could you please rebase this? Once it's done, I'll merge this one.

@jpkrohling
Copy link
Contributor

crossdock-otel job restarted

@jpkrohling jpkrohling merged commit 0a889e8 into jaegertracing:master Sep 14, 2020
@jpkrohling
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run the jaeger-agent as a non-root user by default
3 participants