Consolidated OTel ES IndexNameProviders #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2458 +/- ##
==========================================
+ Coverage 95.57% 95.59% +0.01%
==========================================
Files 208 208
Lines 10690 10690
==========================================
+ Hits 10217 10219 +2
+ Misses 401 399 -2
Partials 72 72
Continue to review full report at Codecov.
|
Signed-off-by: Joe Elliott <number101010@gmail.com>
|
@pavolloffay If you have a chance to look at this I would appreciate it. |
pavolloffay
reviewed
Sep 8, 2020
| @@ -12,39 +12,54 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| package esspanreader | |||
| package esclient | |||
There was a problem hiding this comment.
It should go to a different package than esclient. The esclient is dedicated only for the ES client used by Jaeger writer/reader.
There was a problem hiding this comment.
moved to ./internal/esutil
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
pavolloffay
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
There were two
indexNameProviders with very similar code. One for reading and one for writing. These have been consolidated into one provider in theinternal/esutilpackageShort description of the changes
IndexNameProviders and tests