Check missing server URL in ES OTEL client #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
yurishkuro
approved these changes
Aug 24, 2020
|
Codecov Report
@@ Coverage Diff @@
## master #2411 +/- ##
==========================================
- Coverage 95.56% 95.55% -0.01%
==========================================
Files 208 208
Lines 10676 10676
==========================================
- Hits 10202 10201 -1
Misses 401 401
- Partials 73 74 +1
Continue to review full report at Codecov.
|
yurishkuro
approved these changes
Aug 24, 2020
| @@ -27,6 +27,8 @@ import ( | |||
| "github.com/jaegertracing/jaeger/pkg/es/config" | |||
| ) | |||
|
|
|||
| var errMissingURL = fmt.Errorf("missing Elasticsearch URL") | |||
There was a problem hiding this comment.
nit: errors.New() is a more idiomatic approach for completely static error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay ploffay@redhat.com
@joe-elliott could you please review?