Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask passwords when written as json #2302

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

objectiser
Copy link
Contributor

Signed-off-by: Gary Brown gary@brownuk.com

Which problem is this PR solving?

Ensure that passwords are not accidentally written out as json.

Short description of the changes

Don't serialize the password fields as json.

Signed-off-by: Gary Brown <gary@brownuk.com>
@objectiser objectiser requested a review from a team as a code owner June 22, 2020 16:31
@objectiser objectiser requested a review from yurishkuro June 22, 2020 16:31
@yurishkuro
Copy link
Member

Feels like there's got to be a more reliable way.

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #2302 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2302      +/-   ##
==========================================
- Coverage   96.23%   96.21%   -0.02%     
==========================================
  Files         218      218              
  Lines       10692    10692              
==========================================
- Hits        10289    10287       -2     
- Misses        347      350       +3     
+ Partials       56       55       -1     
Impacted Files Coverage Δ
...lugin/sampling/strategystore/adaptive/processor.go 99.20% <0.00%> (-0.80%) ⬇️
plugin/storage/badger/spanstore/reader.go 96.79% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 126701a...a6d7f9c. Read the comment docs.

@yurishkuro yurishkuro merged commit 049d202 into jaegertracing:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants