Add OTEL ingester component #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2225 +/- ##
==========================================
+ Coverage 96.16% 96.18% +0.01%
==========================================
Files 219 219
Lines 10632 10632
==========================================
+ Hits 10224 10226 +2
+ Misses 352 351 -1
+ Partials 56 55 -1
Continue to review full report at Codecov.
|
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
Signed-off-by: Pavol Loffay <ploffay@redhat.com>
pavolloffay
force-pushed
the
otel-ingester-add
branch
from
0a85c85 to
0bcda88
Compare
objectiser
approved these changes
May 7, 2020
|
|
||
| storageType := os.Getenv(storage.SpanStorageTypeEnvVar) | ||
| if storageType == "" { | ||
| storageType = "cassandra" |
There was a problem hiding this comment.
Just a note: We should discuss this as part of the 2.0 tracker - as Uber are not necessarily going to stick with cassandra, so possibly there shouldn't be a default.
There was a problem hiding this comment.
+1 could you please create an issue for it in area/otel?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2205
Signed-off-by: Pavol Loffay ploffay@redhat.com