Return appropriate gRPC errors/codes to indicate request status #2132
Conversation
Signed-off-by: Yuri Shkuro <ys@uber.com>
yurishkuro
changed the title
| } | ||
| if err != nil { | ||
| g.logger.Error("Could not fetch spans from backend", zap.Error(err)) | ||
| return err | ||
| g.logger.Error("failed to fetch spans from the backend", zap.Error(err)) |
There was a problem hiding this comment.
Logs may be capitalized and with periods while error strings need not (because they are pulled into stack traces)
There was a problem hiding this comment.
I know, but I felt it's simpler to keep strings consistent between errors and logs
| } | ||
| return g.sendSpanChunks(trace.Spans, stream.Send) | ||
| } | ||
|
|
||
| // ArchiveTrace is the GRPC handler to archive traces. | ||
| // ArchiveTrace is the gRPC handler to archive traces. |
There was a problem hiding this comment.
Is everything consistently using this?
There was a problem hiding this comment.
Fixing as I see them. Not important, but less complaints from IDE.
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
| @@ -84,7 +84,7 @@ require ( | |||
| golang.org/x/lint v0.0.0-20200130185559-910be7a94367 | |||
| golang.org/x/net v0.0.0-20200202094626-16171245cfb2 | |||
| golang.org/x/sys v0.0.0-20200217220822-9197077df867 | |||
| golang.org/x/tools v0.0.0-20200227222343-706bc42d1f0d | |||
| golang.org/x/tools v0.0.0-20200227222343-706bc42d1f0d // indirect | |||
There was a problem hiding this comment.
I just ran go mod tidy
Codecov Report
@@ Coverage Diff @@
## master #2132 +/- ##
==========================================
+ Coverage 96.13% 96.15% +0.01%
==========================================
Files 218 218
Lines 10564 10564
==========================================
+ Hits 10156 10158 +2
+ Misses 353 352 -1
+ Partials 55 54 -1
Continue to review full report at Codecov.
|
Which problem is this PR solving?
Short description of the changes